Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve beacon chain explorer #446

Merged

Conversation

Neylix
Copy link
Member

@Neylix Neylix commented Jul 12, 2022

Description

Beacon explorer subscribe to other node and itself to be notified when a new replication attestation is emitted.
But the node is notified for each confirmation while it only needs one confirmation.
Beacon node also notify storage node for a transaction, storages nodes already know the transaction
Beacon explore ask for notification to a node even if it is already subscribed.
All these actions spam a lot the node and they can get overloaded.

This PR solves these issue.

Fixes part of #425

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Add some latency in connection.ex (Process.sleep(200)), run 3 nodes, open a beacon explorer and you should not have a lot of timeout after some time

Also added test files

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Neylix Neylix requested a review from imnik11 July 12, 2022 11:03
@Neylix Neylix merged commit 2ec297b into archethic-foundation:develop Jul 12, 2022
@Neylix Neylix deleted the Improve-Beacon-Chain-explorer branch July 12, 2022 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant