Replicate only missing transactions #443 #453
Conversation
lib/archethic.ex
Outdated
| """ | ||
| @spec get_last_transaction_address_locally(address :: binary()) :: | ||
| {:ok, binary()} | {:error, :not_found} | {:error, :network_issue} | ||
| def get_last_transaction_address_locally(address) when is_binary(address) do |
There was a problem hiding this comment.
This function may be in TransactionChain module, same for get_genesis_transaction_address, fetch_transaction_chain_locally and available_loccaly? as we request an information of a transaction chain
lib/archethic.ex
Outdated
| def available_locally?(address) when is_binary(address) do | ||
| case get_last_transaction_address_locally(address) do | ||
| {:ok, last_address} -> {true, last_address} | ||
| {:error, :not_found} -> {false, nil} |
There was a problem hiding this comment.
You should also catch {:error, :network_issue}
Also in case of wrong result, you can juste return false, nil is not used after
lib/archethic.ex
Outdated
|
|
||
| chain_page = | ||
| paging_address | ||
| |> TransactionChain.stream_remotely(nodes) |
There was a problem hiding this comment.
This function aims to get the local transaction chain, but you get it remotely so it's not the local chain.
You should use TransactionChain.get
There was a problem hiding this comment.
I am querying the same node via P2P.message abstraction.
It twill be more secure rather than directly querying the DB.
lib/archethic/transaction_chain.ex
Outdated
| @doc """ | ||
| Retrieve the genesis address of a chain | ||
| """ | ||
| @spec resolve_last_address(binary()) :: {:ok, binary()} | {:error, :network_issue} |
There was a problem hiding this comment.
Spec definition so not martch the function name.
Same for fetch_genesis_address_remotely
apoorv-2204
force-pushed
the
replicate_txn_chain_443
branch
from
36e9584
to
9689fc5
Compare
apoorv-2204
added
bug
- included new method fetch chain efficiently - add checks before fetching txn chain - resolve tests
apoorv-2204
force-pushed
the
replicate_txn_chain_443
branch
from
9d7c6cf
to
cbe81d5
Compare
Description
Fixes # (#443)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Checklist: