Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schedule sending of reward tokens to the node reward address #477

Conversation

Neylix
Copy link
Member

@Neylix Neylix commented Jul 27, 2022

Description

After the mint reward, we send to the node reward to all authorized nodes.

Fixes #382

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

node reward transaction is sent after the mint reward one, or if there is no mint reward transaction to do the node reward tx is directly sent.

Add test in test files.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Neylix Neylix merged commit dd4550c into archethic-foundation:develop Jul 29, 2022
@Neylix Neylix deleted the Schedule-sending-of-reward-tokens-to-the-node-reward-address branch July 29, 2022 09:43
@Neylix Neylix added the feature New feature request label Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant