Resovles:Enforce resync of last network transactions after bootstrap#508 #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
1 task
apoorv-2204
force-pushed
the
enforce_loading_of_network_txs
branch
from
401e2c9
to
e31956e
Compare
apoorv-2204
changed the title
apoorv-2204
force-pushed
the
enforce_loading_of_network_txs
branch
from
8eb1a90
to
0e70a09
Compare
ghost
reviewed
Aug 18, 2022
apoorv-2204
added
transaction
ghost
reviewed
Aug 19, 2022
ghost
reviewed
Aug 19, 2022
|
Also please describe more the flow how to test it |
apoorv-2204
force-pushed
the
enforce_loading_of_network_txs
branch
from
1befdf3
to
ff99d03
Compare
apoorv-2204
force-pushed
the
enforce_loading_of_network_txs
branch
2 times, most recently
from
4336fb8
to
2eb67d2
Compare
Neylix
requested changes
Aug 24, 2022
apoorv-2204
force-pushed
the
enforce_loading_of_network_txs
branch
from
2eb67d2
to
5e40c86
Compare
ghost
suggested changes
Aug 25, 2022
apoorv-2204
force-pushed
the
enforce_loading_of_network_txs
branch
2 times, most recently
from
5691c01
to
19aca28
Compare
Neylix
requested changes
Aug 30, 2022
apoorv-2204
force-pushed
the
enforce_loading_of_network_txs
branch
from
19aca28
to
305b7a0
Compare
Neylix
requested changes
Aug 31, 2022
There was a problem hiding this comment.
Some updates to do in testfile, I think you have to control if the transaction has been writen in DB.
You can add a MockDB on write_transaction_chain and send to the process a message that to inform we entered in this function.
Then you can add an assert_receive in the test to control that you correctly writted the transaction
apoorv-2204
force-pushed
the
enforce_loading_of_network_txs
branch
from
419b5b9
to
fd7fc3c
Compare
apoorv-2204
force-pushed
the
enforce_loading_of_network_txs
branch
from
fd7fc3c
to
3d36716
Compare
Neylix
approved these changes
Sep 9, 2022
samuelmanzanera
pushed a commit
that referenced
this pull request
Sep 9, 2022
If there is quick disconnection and re-connection of a (authorised and available) node, it is a possibility that it will miss some oracle and node shared secrets transactions , which results in inconsistent node state.Post bootstrap we must resync node shared secrets and oracle txs so that current node state is same as other nodes state. So during validation it will not report invalid tx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If there is quick disconnection and re-connection of a (authorised and available) node, it is a possibility that it will miss some oracle and node shared secrets transactions , which results in inconsistent node state.Post Bootstrap ,we must resync nss and oracle txs so that current node state is same as other nodes state. So during validation it will not report invalid tx
Fixes # (#508 )
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
How to test?
Checklist: