Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve last address conflicts #527

Merged
3 commits merged into from
Aug 19, 2022
Merged

Resolve last address conflicts #527

3 commits merged into from
Aug 19, 2022

Conversation

ghost
Copy link

@ghost ghost commented Aug 18, 2022

Description

Provide last address conflict resolution and return timestamp in the LastTransactionAddress.
So changes in the chain index database are required.

Fixes #520

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

To test this feature, you start a node. Create a transaction on chain (for example AEWeb)
Then add another node, await the node replicate the transaction in the self-repair and become available (yet not authorized)
Then create another transaction on the chain. (the transaction should be replicated on the first node)
Then request the last update of the chain, the latest value should be retrieved while being called to the both nodes and the conflict resolutions should happen.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@ghost ghost added feature New feature request P2P Involve P2P networking labels Aug 18, 2022
@ghost ghost requested a review from Neylix August 18, 2022 13:38
@ghost ghost force-pushed the resolve_last_address_conflicts branch from 37884d9 to fb05c33 Compare August 19, 2022 08:23
@ghost ghost merged commit 20f7548 into develop Aug 19, 2022
@ghost ghost deleted the resolve_last_address_conflicts branch August 19, 2022 08:50
ghost pushed a commit that referenced this pull request Aug 25, 2022
* Return last transaction address time from DB

* Add timestamp in the LastTransactionAddress message

* Handle conflict on last transaction address
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature request P2P Involve P2P networking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant