Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix get transaction chain lookup #528

Merged
1 commit merged into from
Aug 19, 2022
Merged

Conversation

ghost
Copy link

@ghost ghost commented Aug 18, 2022

Description

Fix the transaction chain reading to make sure the chain is one expected, so bigger.
Since d244b1d, the chain was downloaded using a diff between local and remote fetch.

The problem being, if a local chain was bigger than the address of the chain requested (pointer) we would include more transaction than expected. And also we might cause database issues, because the pagination address was the latest one, which don't provide much transactions to load.

This fix makes sure we only download the right transactions until the desired transaction's address.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@ghost ghost added bug Something isn't working P2P Involve P2P networking labels Aug 18, 2022
@ghost ghost changed the base branch from master to develop August 18, 2022 14:45
@ghost ghost requested a review from apoorv-2204 August 18, 2022 14:45
@apoorv-2204
Copy link
Contributor

LGTM

@ghost ghost force-pushed the fix_get_transaction_chain_lookup branch from e43fdb2 to c0e4d36 Compare August 18, 2022 17:11
@ghost ghost requested a review from Neylix August 18, 2022 17:53
@ghost ghost force-pushed the fix_get_transaction_chain_lookup branch from c0e4d36 to 53720c7 Compare August 19, 2022 08:59
@ghost ghost merged commit 2cf7a6e into develop Aug 19, 2022
@ghost ghost deleted the fix_get_transaction_chain_lookup branch August 19, 2022 09:09
ghost pushed a commit that referenced this pull request Aug 25, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P2P Involve P2P networking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants