Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Election with only available and authorized nodes #530

Merged

Conversation

apoorv-2204
Copy link
Contributor

@apoorv-2204 apoorv-2204 commented Aug 19, 2022

Description

We should use only authorised and available nodes for election, to have consistent shard info .

ommitted files -
node_renewal.ex
node_map live.ex

Fixes # (521)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • mix test
  • distributed testing

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@apoorv-2204 apoorv-2204 force-pushed the election_with_auth_avail_nodes branch from bceeed9 to bbb8c67 Compare August 19, 2022 15:26
@apoorv-2204 apoorv-2204 self-assigned this Aug 19, 2022
@apoorv-2204 apoorv-2204 requested a review from a user August 19, 2022 15:29
@apoorv-2204 apoorv-2204 marked this pull request as ready for review August 19, 2022 15:29
@apoorv-2204 apoorv-2204 added self repair Involve SelfRepair mechanism bootstrap labels Aug 19, 2022
@apoorv-2204 apoorv-2204 added core team Assigned to the core team bug Something isn't working and removed self repair Involve SelfRepair mechanism bootstrap labels Aug 22, 2022
@ghost ghost removed their request for review August 23, 2022 06:55
@apoorv-2204 apoorv-2204 requested review from Neylix and removed request for imnik11 August 23, 2022 12:12
@ghost ghost merged commit 3ee44a9 into archethic-foundation:develop Aug 23, 2022
ghost pushed a commit that referenced this pull request Aug 25, 2022
@apoorv-2204 apoorv-2204 deleted the election_with_auth_avail_nodes branch August 29, 2022 15:10
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working core team Assigned to the core team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants