Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bootstrap issue #537

Merged
4 commits merged into from
Aug 23, 2022
Merged

Conversation

Neylix
Copy link
Member

@Neylix Neylix commented Aug 22, 2022

Description

Fixe some error hapening on bootstrap :

  • Start the tcp listener after the bootstrap to avoid connection and disconnection on the other nodes
  • As now a node can send message but without starting the tcp listener, we remove the set_connected function as the node may not be connected
  • Fix an error during self repair: if there is more dates to sync than CPU cores, some beacon summaries with different timestamp where aggregated together causing a crash on transaction loading

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Launch a node and wait half an hour to let it generate more than 30 summaries.
Create some transfer transaction
Start a second node and the should load all the transaction sorted by timestamp

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Neylix Neylix requested a review from a user August 22, 2022 10:36
lib/archethic/bootstrap.ex Outdated Show resolved Hide resolved
lib/archethic/p2p/client/connection.ex Show resolved Hide resolved
lib/archethic/p2p/listener.ex Outdated Show resolved Hide resolved
@ghost ghost added bug Something isn't working bootstrap labels Aug 23, 2022
@ghost ghost merged commit db6383b into archethic-foundation:develop Aug 23, 2022
@Neylix Neylix deleted the Fix-bootstrap-issue branch August 25, 2022 07:32
ghost pushed a commit that referenced this pull request Aug 25, 2022
* Remove update connection when receiving a message
* Fix self repair error when having more dates to synchronize than CPU core
* Start listener after bootstrap
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bootstrap bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant