Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix replication transaction chain ordering writing #545

Merged
merged 3 commits into from
Aug 31, 2022

Conversation

ghost
Copy link

@ghost ghost commented Aug 26, 2022

Description

Fix the replication transaction chain (due to regression)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@ghost ghost added bug Something isn't working replication labels Aug 26, 2022
@ghost ghost requested a review from Neylix August 26, 2022 15:30
lib/archethic/replication.ex Outdated Show resolved Hide resolved
Copy link
Member

@Neylix Neylix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is also a test error.
in sync test a mockDB on write_transaction_chain is defined to send an event, but we don't always use write_transaction_chain. In the test case it should be write_transaction

@samuelmanzanera samuelmanzanera merged commit be89a14 into develop Aug 31, 2022
@samuelmanzanera samuelmanzanera deleted the fix_replicate_transaction_chain branch August 31, 2022 13:04
samuelmanzanera added a commit that referenced this pull request Sep 9, 2022
* Fix replication transaction chain ordering writing
* Add telemetry of full replication chain write
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working replication
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants