Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add timeout in standalone workflow #550

Merged
merged 2 commits into from
Aug 31, 2022
Merged

Add timeout in standalone workflow #550

merged 2 commits into from
Aug 31, 2022

Conversation

samuelmanzanera
Copy link
Member

Description

Provide timeouts for standalone workflow helping to clean mining processes

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@samuelmanzanera samuelmanzanera added bug Something isn't working mining Involve transaction validation and mining labels Aug 29, 2022
prix-uniris
prix-uniris approved these changes Aug 30, 2022
View reviewed changes
Copy link
Contributor

@prix-uniris prix-uniris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samuelmanzanera samuelmanzanera merged commit 48cf981 into develop Aug 31, 2022
@samuelmanzanera samuelmanzanera deleted the add_timeout_in_standalone_workflow branch August 31, 2022 13:05
samuelmanzanera added a commit that referenced this pull request Sep 9, 2022
@samuelmanzanera
Add process clenaup in standalone workflow (#550)
76e4fa3 
* Add timeout in standalone workflow
* Stop mining process with enough confirmations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Neylix Neylix Neylix approved these changes

@prix-uniris prix-uniris prix-uniris approved these changes

Assignees
No one assigned
Labels
bug Something isn't working mining Involve transaction validation and mining
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@samuelmanzanera @Neylix @prix-uniris