Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start Schedulers Post Bootstrap #543 #552

Conversation

apoorv-2204
Copy link
Contributor

@apoorv-2204 apoorv-2204 commented Aug 30, 2022

Description

Scheduler must start only after post Bootstrap, So that no new next txn are sent during bootstrap .
During crash scheduler must read arch-ethic_up before starting.

Affected Schedulers

  • Reward
  • Oracle
  • Node Renewal
  • Slot timer

Fixes # (#543)

Type of change

How Has This Been Tested?

  • Unit Test cases.
  • Distributed Testing.

Logs were checked to ensure the scheduler started post Bootstrap Finished message.

Screenshot_20220906_161508

explicitly killing a scheduler
Screenshot_20220906_162836

How to test?

Use Logs to confirm that schedulers started post bootstrap finished message.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@apoorv-2204 apoorv-2204 marked this pull request as ready for review September 1, 2022 12:39
@apoorv-2204 apoorv-2204 added oracle chain Involve OracleChain core team Assigned to the core team rewards bootstrap labels Sep 1, 2022
@apoorv-2204 apoorv-2204 requested review from samuelmanzanera and Neylix and removed request for Neylix September 1, 2022 15:51
@apoorv-2204 apoorv-2204 self-assigned this Sep 2, 2022
lib/archethic/account/mem_tables_loader.ex Outdated Show resolved Hide resolved
lib/archethic/bootstrap.ex Outdated Show resolved Hide resolved
lib/archethic/oracle_chain/scheduler.ex Outdated Show resolved Hide resolved
@apoorv-2204
Copy link
Contributor Author

Testing: we looked for Bootstrap message and post that scheduler must start.
Screenshot_20220905_120007

if Node is still bootstrapping scheduler/timer must wait .
Screenshot_20220905_120354

- fix tests
- change to node_up
@samuelmanzanera samuelmanzanera merged commit 70138e9 into archethic-foundation:develop Sep 8, 2022
@apoorv-2204 apoorv-2204 deleted the start_scheduler_post_up branch September 15, 2022 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bootstrap bug Something isn't working core team Assigned to the core team oracle chain Involve OracleChain rewards
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants