Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add buttons to copy content and code to transaction details #579

Merged

Conversation

kevin-btc
Copy link
Contributor

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List

  • Add Button to copy content or smart contract code in clipboard (issue #438)
  • No dependency required

Screen Shot 2022-09-20 at 12 46 39

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Create a transaction with content and a smart contract code.
  • After submitting the transaction, you need to go to the transaction details.
  • In the transaction details, click on Data > Code in the left menu.
  • Click the "copy" button in the smart contract code field and paste it somewhere.
  • Do the same thing for Data > content

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@kevin-btc kevin-btc marked this pull request as ready for review September 21, 2022 17:27
@Neylix Neylix added UI Invole user interface external contribution Contribution by non core team labels Sep 22, 2022
Copy link
Member

@Neylix Neylix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello !
Happy to see your first PR on the project, welcome !
Copy function works well, I have just one remark to have a smoother user experience

assets/js/app.js Outdated Show resolved Hide resolved
@kevin-btc
Copy link
Contributor Author

I took your remarks into consideration and modified the code. I tried with a notification like bulma but it was too much.

@samuelmanzanera samuelmanzanera merged commit 9ee7971 into archethic-foundation:develop Sep 26, 2022
@samuelmanzanera samuelmanzanera added the feature New feature request label Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external contribution Contribution by non core team feature New feature request UI Invole user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants