Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some display / API issue #600

Merged

Conversation

Neylix
Copy link
Member

@Neylix Neylix commented Oct 3, 2022

Description

Fix some issue affecting explorer and API

  • %GetBalance message: amount serialized in float instead of integer, it was returning number in scientific notation (3e8) but this notation is not handled in Absinthe serialization.
  • Metric poller : when using upnp, some router do not open port for local request on public ip (public_ip:port does not work but local_ip:port does work). If not request metrics to iteself, changed ip to 127.0.0.1
  • Oracle chain on explorer is firstly loaded in chronologic order, but when a new transaction comes, the transaction is prepended causing an inconsistencie in the transaction order

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

%GetBalance message return integer value correctly
Metric poller can fetch metric from local ip correclty

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Using upnp on some router do not allow requesting public ip from the router itslef
For metric polling, if node request itself, replace public ip by 127.0.0.1
Use 64 bits instead of float as all numbers are in Big Int
@Neylix Neylix added bug Something isn't working serialization Involve message serialization networking Involve networking labels Oct 3, 2022
@Neylix Neylix changed the base branch from master to develop October 3, 2022 19:00
@samuelmanzanera samuelmanzanera merged commit 4a5eac8 into archethic-foundation:develop Oct 4, 2022
@Neylix Neylix deleted the Fix-some-display-issue branch October 4, 2022 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working networking Involve networking serialization Involve message serialization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants