Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use NV indexes to store node's seed in TPM #602

Merged
merged 3 commits into from
Oct 7, 2022

Conversation

samuelmanzanera
Copy link
Member

@samuelmanzanera samuelmanzanera commented Oct 4, 2022

Description

Leverage TPM NV indexes to store the node seed generated by secure random generator from the TPM.
This allows to provide a secure backup for the node seed.

Fixes #589

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Start a node with TPM activated.
Then reboot and restart the app, the seed should remain the same.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@samuelmanzanera samuelmanzanera marked this pull request as ready for review October 4, 2022 09:38
@samuelmanzanera samuelmanzanera added feature New feature request crypto Involve cryptography system Involve system management labels Oct 4, 2022
@samuelmanzanera samuelmanzanera merged commit fa5fad4 into develop Oct 7, 2022
@samuelmanzanera samuelmanzanera deleted the secure_node_seed_tpm branch October 7, 2022 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crypto Involve cryptography feature New feature request system Involve system management
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants