Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix trigger validation in SC tx acceptance #617

Merged
merged 1 commit into from
Oct 12, 2022

Conversation

samuelmanzanera
Copy link
Member

@samuelmanzanera samuelmanzanera commented Oct 10, 2022

Description

This fix the validation of triggers from a transaction generated from a smart contract.
Before it expects all the triggers to be true which is not possible.
So this change ensures at least one trigger have been the source of the tx.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@samuelmanzanera samuelmanzanera added bug Something isn't working smart contracts Involve smart contracts labels Oct 10, 2022
@samuelmanzanera samuelmanzanera self-assigned this Oct 11, 2022
@samuelmanzanera samuelmanzanera merged commit 451442c into develop Oct 12, 2022
@samuelmanzanera samuelmanzanera deleted the fix_sc_valid_triggers branch October 12, 2022 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working smart contracts Involve smart contracts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants