Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix beacon date projections #653

Merged
merged 5 commits into from
Oct 28, 2022
Merged

Fix beacon date projections #653

merged 5 commits into from
Oct 28, 2022

Conversation

samuelmanzanera
Copy link
Member

Description

Fix invalid slot times causing drift of transaction timestamping on the beacon

Type of change

  • Bug fix (non-breaking change which fixes an issue

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@samuelmanzanera samuelmanzanera added beacon chain Involve BeaconChain external contribution Contribution by non core team labels Oct 25, 2022
@samuelmanzanera samuelmanzanera changed the title Fix slot/summary timer prev/next function Fix beacon date projections Oct 25, 2022
Neylix
Neylix reviewed Oct 25, 2022
View reviewed changes
Copy link
Member

@Neylix Neylix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this behavior should bea applied to all scheduler (oracle, reward ...).
To simplify it, maybe we can create a function in utils (next_date and previous_date) where we just pass the cron_expression and the date.

lib/archethic/beacon_chain/slot_timer.ex Outdated Show resolved Hide resolved
lib/archethic/beacon_chain/subset.ex Outdated Show resolved Hide resolved
lib/archethic/self_repair/sync.ex Outdated Show resolved Hide resolved
@samuelmanzanera samuelmanzanera added core team Assigned to the core team and removed external contribution Contribution by non core team labels Oct 27, 2022
@samuelmanzanera samuelmanzanera merged commit 73d4258 into develop Oct 28, 2022
@samuelmanzanera samuelmanzanera deleted the fix_beacon_date_projections branch October 28, 2022 06:50
@Neylix Neylix added the bug Something isn't working label Oct 31, 2022
samuelmanzanera added a commit that referenced this pull request Nov 14, 2022
@samuelmanzanera
Fix beacon date projections (#653)
420cda6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Neylix Neylix Neylix approved these changes

Assignees
No one assigned
Labels
beacon chain Involve BeaconChain bug Something isn't working core team Assigned to the core team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@samuelmanzanera @Neylix