Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #658

Merged

Conversation

cluster
Copy link
Contributor

@cluster cluster commented Oct 26, 2022

Description

This PR updates elixir dependencies. It mainly affects phoenix (1.6) and liveview (and refactoring .html.eex or .html.leex files to .html.heex) and using esbuild instead of webpack.

Webpack was used (among others) to convert scss to css, so it's been replaced by dart_sass, as advised here. But unfortunately dart_sass couldn't be used to build the docker image because it's not compatible with alpine, as a workaroung it's using sass installed through npm.

This PR also contains a commit from this PR.

Note: Because git_hooks has been updated, it might be necessary to run mix git_hooks.install in case this error occurs when trying to git push:

Unchecked dependencies for environment dev:
* blankable (Hex package)
  the dependency is not available, run "mix deps.get"
* ex_doc (Hex package)
  the dependency is not available, run "mix deps.get"
* recase (Hex package)
  the dependency is not available, run "mix deps.get"
* dialyxir (Hex package)
  the dependency is not available, run "mix deps.get"
* credo (Hex package)
  the dependency is not available, run "mix deps.get"
** (Mix) Can't continue due to errors on dependencies

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

A few tests have been run locally, like doing a transfer.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@samuelmanzanera samuelmanzanera added external contribution Contribution by non core team dependencies Pull requests that update a dependency file labels Oct 27, 2022
@samuelmanzanera
Copy link
Member

Transaction details's page is failing due to errors with AlpineJS

image

@samuelmanzanera samuelmanzanera merged commit 42de9d9 into archethic-foundation:develop Oct 28, 2022
@apoorv-2204
Copy link
Contributor

😄

samuelmanzanera pushed a commit that referenced this pull request Nov 14, 2022
* Upgrade phoenix to 1.6

* Replace .html.eex/.html.leex by .html.heex and ~L by ~H

* Update other dependencies

* Install esbuild (and get rid of webpack)

* Update dependencies

* Update cors_plug

* Set deps versions to MAJOR.MINOR and check for deps updates

* Fix alpine error by upgrading esbuild target version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file external contribution Contribution by non core team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants