-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies #658
Merged
samuelmanzanera
merged 9 commits into
archethic-foundation:develop
from
cluster:update_dependencies
Oct 28, 2022
Merged
Update dependencies #658
samuelmanzanera
merged 9 commits into
archethic-foundation:develop
from
cluster:update_dependencies
Oct 28, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e7b5dbd
to
14ac308
Compare
samuelmanzanera
approved these changes
Oct 28, 2022
😄 |
samuelmanzanera
pushed a commit
that referenced
this pull request
Nov 14, 2022
* Upgrade phoenix to 1.6 * Replace .html.eex/.html.leex by .html.heex and ~L by ~H * Update other dependencies * Install esbuild (and get rid of webpack) * Update dependencies * Update cors_plug * Set deps versions to MAJOR.MINOR and check for deps updates * Fix alpine error by upgrading esbuild target version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dependencies
Pull requests that update a dependency file
external contribution
Contribution by non core team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates elixir dependencies. It mainly affects phoenix (1.6) and liveview (and refactoring .html.eex or .html.leex files to .html.heex) and using esbuild instead of webpack.
Webpack was used (among others) to convert scss to css, so it's been replaced by dart_sass, as advised here. But unfortunately dart_sass couldn't be used to build the docker image because it's not compatible with alpine, as a workaroung it's using sass installed through npm.
This PR also contains a commit from this PR.Note: Because
git_hooks
has been updated, it might be necessary to runmix git_hooks.install
in case this error occurs when trying togit push
:Type of change
Please delete options that are not relevant.
How Has This Been Tested?
A few tests have been run locally, like doing a transfer.
Checklist: