New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle ipv6 local ip in node settings page #666

Merged

samuelmanzanera merged 1 commit into archethic-foundation:develop from Neylix:Fix-settings-page-local-ip-detection

Nov 4, 2022

Member

Neylix commented Nov 4, 2022

Description

Node settings page on explorer is only available on local network. The filter to verify if client ip is local do not handle ipv6 address.

Type of change

Bug fix (non-breaking change which fixes an issue)

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
Any dependent changes have been merged and published in downstream modules


          Handle ipv6 local ip in node settings page

f73b117

Neylix added bug UI labels

samuelmanzanera approved these changes

View reviewed changes

samuelmanzanera merged commit b70288d into archethic-foundation:develop

Neylix deleted the Fix-settings-page-local-ip-detection branch

November 5, 2022 12:30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment