Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure destination of elected message #674

Merged
merged 1 commit into from
Nov 17, 2022
Merged

Ensure destination of elected message #674

merged 1 commit into from
Nov 17, 2022

Conversation

samuelmanzanera
Copy link
Member

Description

Fixes #646

Type of change

Please delete options that are not relevant.

  • Enhancement

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@samuelmanzanera samuelmanzanera added P2P Involve P2P networking core team Assigned to the core team enhancements labels Nov 8, 2022
@samuelmanzanera samuelmanzanera self-assigned this Nov 8, 2022
@Neylix Neylix linked an issue Nov 9, 2022 that may be closed by this pull request
Ensure right destination of P2P messages #646
Closed
7 tasks
Neylix
Neylix reviewed Nov 16, 2022
View reviewed changes
Copy link
Member

@Neylix Neylix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the goal to add sender_public_key in message process, as it is never used ?

@samuelmanzanera
Copy link
Member Author

What is the goal to add sender_public_key in message process, as it is never used ?

The goal is to prepare in the case whether the message have been sent by the right peer.

@samuelmanzanera samuelmanzanera force-pushed the check_message_destination branch 5 times, most recently from fbcabd6 to 71832a6 Compare November 17, 2022 08:22
@samuelmanzanera samuelmanzanera merged commit 2316610 into develop Nov 17, 2022
@samuelmanzanera samuelmanzanera deleted the check_message_destination branch November 17, 2022 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Neylix Neylix Neylix approved these changes

Assignees

@samuelmanzanera samuelmanzanera

Labels
core team Assigned to the core team enhancements P2P Involve P2P networking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ensure right destination of P2P messages
2 participants
@samuelmanzanera @Neylix