Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update opt25 fork distillery #680

Conversation

cluster
Copy link
Contributor

@cluster cluster commented Nov 10, 2022

Description

The goal of this PR is to update OTP to version 25.
Since distillery isn't compatible with OTP25 (and is no longer active), a fork has been made to fix the issue.

We could also remove distillery from the project, but because hot code upgrade is necessary (and distillery has so much tools for it), we had to keep it.

⚠️ The distillery PR needs to be merged and mix deps.update distillery needs to be run (and the new mix.lock needs to be commited) before merging this PR.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Tested locally and with the docker image. Doing transactions...

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@cluster cluster marked this pull request as draft November 10, 2022 15:47
@samuelmanzanera samuelmanzanera added system Involve system management external contribution Contribution by non core team labels Nov 10, 2022
@samuelmanzanera samuelmanzanera marked this pull request as ready for review November 10, 2022 16:49
@apoorv-2204
Copy link
Contributor

OTP 25 👍

@samuelmanzanera
Copy link
Member

Test with mix distillery.release => 👍

@samuelmanzanera
Copy link
Member

We just got the error on the test to resolve.

@cluster
Copy link
Contributor Author

cluster commented Nov 14, 2022

We just got the error on the test to resolve.

I was hopping it was due to a problem on my local environment 😅
It's so strange because when I add

{a, _} = :erlang.process_info(self(), :message_queue_data)
IO.puts(a)

to the test, it just works... 🤷‍♂️

I'm going to investigate to find out the source of this issue 🤔

@samuelmanzanera
Copy link
Member

Tests passed now

@samuelmanzanera
Copy link
Member

Tested with hot reload (distillery upgrades)

@samuelmanzanera samuelmanzanera merged commit 96274d6 into archethic-foundation:develop Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external contribution Contribution by non core team system Involve system management
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants