Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Proof of work existence for node transaction #681

Merged
merged 1 commit into from
Nov 14, 2022
Merged

Fix Proof of work existence for node transaction #681

merged 1 commit into from
Nov 14, 2022

Conversation

samuelmanzanera
Copy link
Member

@samuelmanzanera samuelmanzanera commented Nov 14, 2022 •
edited
Loading

Description

This PR aims to resolve a bug introduced in 0aa0577.

Because node transaction doesn't leverage existing origin key for their first transaction. We have to use existing list origin key candidates to avoid code repetition.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@samuelmanzanera samuelmanzanera added bug Something isn't working mining Involve transaction validation and mining core team Assigned to the core team labels Nov 14, 2022
apoorv-2204
apoorv-2204 reviewed Nov 14, 2022
View reviewed changes
lib/archethic/mining/validation_context.ex
@@ -1026,7 +1025,7 @@ defmodule Archethic.Mining.ValidationContext do

_ ->
Transaction.verify_origin_signature?(tx, pow) and
SharedSecrets.has_origin_public_key?(pow)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

,,

apoorv-2204
apoorv-2204 suggested changes Nov 14, 2022
View reviewed changes
lib/archethic/mining/validation_context.ex
@@ -1026,7 +1025,7 @@ defmodule Archethic.Mining.ValidationContext do

_ ->
Transaction.verify_origin_signature?(tx, pow) and
SharedSecrets.has_origin_public_key?(pow)
pow in ProofOfWork.list_origin_public_keys_candidates(tx)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unit tests

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is already tests for this check:

archethic-node/test/archethic/mining/validation_context_test.exs

Line 75 in 0aa0577

test "should get inconsistency when the proof of work is not in authorized keys" do

apoorv-2204
apoorv-2204 approved these changes Nov 14, 2022
View reviewed changes
Copy link
Contributor

@apoorv-2204 apoorv-2204 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot_20221114_172757

@samuelmanzanera samuelmanzanera merged commit a15eed8 into develop Nov 14, 2022
@samuelmanzanera samuelmanzanera deleted the fix_pow_validation_for_node branch November 14, 2022 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apoorv-2204 apoorv-2204 apoorv-2204 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working core team Assigned to the core team mining Involve transaction validation and mining
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@samuelmanzanera @apoorv-2204