-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move inputs from ETS to disk #684
Move inputs from ETS to disk #684
Conversation
there is one file per address
there is one file per address
we need the prefix to avoid one ledger overriding the content of the other
IMPORTANT NOTE: we loose millisecond precision due to serialization using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, I wrote you some comments to improve it in terms of performances and maintainability.
separation between writer (gen server) and reader (function call)
If we would like to preserve it, we can use |
UCO are either all spent or all unspent, so no need to read from disk if the ETS table contains spent uco
Tokens are either all spent or all unspent, so no need to read from disk if the ETS table contains spent tokens
Description
Once a UTXO is spent, we move it to disk to reduce memory footprint.
Fixes #624
Type of change
How Has This Been Tested?
This is tested in the integration tests.
I did not do any BEFORE/AFTER metrics, should I do some benchmark?
Checklist: