Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Task's timeout handling #685

Merged
merged 1 commit into from
Nov 14, 2022
Merged

Conversation

samuelmanzanera
Copy link
Member

Description

This PR improve Task's timeout handling to stop the task properly.

Type of change

Enhancement

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@samuelmanzanera samuelmanzanera merged commit 5dbd9da into develop Nov 14, 2022
@samuelmanzanera samuelmanzanera deleted the improve_task_timeout branch November 14, 2022 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beacon chain Involve BeaconChain enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants