Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix recursion of notify last address #688

Merged
merged 1 commit into from
Nov 17, 2022

Conversation

samuelmanzanera
Copy link
Member

Description

Fix infinite recursion of last address notification.

Before, the notification was done by each storage nodes of each previous transactions as recursion.
Now, to avoid infinite loop and improve performances, the storage nodes of the transaction will trigger and elect the right unique nodes to be notified. (because they know all the transaction of the last chain)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@samuelmanzanera samuelmanzanera added bug Something isn't working P2P Involve P2P networking replication labels Nov 16, 2022
@samuelmanzanera samuelmanzanera merged commit 376a273 into develop Nov 17, 2022
@samuelmanzanera samuelmanzanera deleted the fix_notify_last_address branch November 17, 2022 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P2P Involve P2P networking replication
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants