Connection's reconnect is asynchronous #721
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reconnect workflow used to be synchronous, which meant all incoming messages were queued to be processed later, and the callers had to wait until eventually they receive a :timeout.
This PR changed the reconnect workflow to be asynchronous, so the callers can get a :closed error message without delay.
NOTE: the first connection is still asynchronous to be able to keep existing code.
Fixes #710
Type of change
How Has This Been Tested?
Case added to the unit tests
Checklist: