-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add new Api to get beacon chain aggregate #746
Merged
Neylix
merged 15 commits into
archethic-foundation:develop
from
tenmoves:create_new_api_to_get_beacon_aggregate
Jan 10, 2023
Merged
add new Api to get beacon chain aggregate #746
Neylix
merged 15 commits into
archethic-foundation:develop
from
tenmoves:create_new_api_to_get_beacon_aggregate
Jan 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Neylix
requested changes
Dec 16, 2022
Neylix
reviewed
Dec 16, 2022
322e0ab
to
ea01aaa
Compare
d8f58d1
to
f72dbc0
Compare
@bchamagne the behaviour you have detected is because you only have a single node running. |
Neylix
approved these changes
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
API
Involve API facing user
beacon chain
Involve BeaconChain
core team
Assigned to the core team
feature
New feature request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since the PR #559 beacon and beacon summaries are not anymore transactions. Before we could get these transaction using graphql API networkTransaction, but now we don't have any way to get the summary data.
We create a new schema in graphql like beaconSummary with a timestamp in parameter which returns the beacon aggregate for this date.
If the date is the last summary date, API should use beacon summary and not beacon aggregate as it is done in explorer.
example graphql query
Fixes #639
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: