Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add buning address to io storage nodes only if burning is intentionna… #749

Conversation

netboz
Copy link
Contributor

@netboz netboz commented Dec 8, 2022

…l (#711)

Description

Store burning fee movements only if they are intentionnals

Fixes # (issue)

  • Now checking if the burning node address is part of the transaction movement list's recipients, to guess if fee burning was intentionnal. If not intentionnal, remove the burning address from resolved io storage nodes

  • kept the test wich will add the burning address to the transaction movements if some burning movements have been recorded from point above.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

test coming soon

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@netboz netboz force-pushed the pr_711_dont_store_burning_fee_transactions_if_burning_not_intentionnal branch from 6942b01 to 829d1a8 Compare December 15, 2022 15:38
@samuelmanzanera
Copy link
Member

I think you can also remove this part as it's useless now

https://github.com/archethic-foundation/archethic-node/blob/develop/lib/archethic/account/mem_tables_loader.ex#L99-L118

@Neylix
Copy link
Member

Neylix commented Dec 19, 2022

It's ok for me, just need to fix the error on compilation due to unused aliases, and dialyzer issue with the fee variable not used anymore in the mem_table_loader.
There's also a conflict with develop branch, doing a rebase should resolve this conflict

@netboz netboz force-pushed the pr_711_dont_store_burning_fee_transactions_if_burning_not_intentionnal branch from 333a929 to c952364 Compare December 21, 2022 14:12
@netboz netboz force-pushed the pr_711_dont_store_burning_fee_transactions_if_burning_not_intentionnal branch from ff5c9b0 to 003833c Compare December 21, 2022 16:39
@netboz netboz requested a review from Neylix December 22, 2022 11:18
@samuelmanzanera samuelmanzanera linked an issue Dec 22, 2022 that may be closed by this pull request
@samuelmanzanera samuelmanzanera merged commit 57132b7 into archethic-foundation:develop Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Burned fee transfer should not be sent to IO node
5 participants