-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add buning address to io storage nodes only if burning is intentionna… #749
Merged
samuelmanzanera
merged 12 commits into
archethic-foundation:develop
from
netboz:pr_711_dont_store_burning_fee_transactions_if_burning_not_intentionnal
Dec 22, 2022
Merged
Add buning address to io storage nodes only if burning is intentionna… #749
samuelmanzanera
merged 12 commits into
archethic-foundation:develop
from
netboz:pr_711_dont_store_burning_fee_transactions_if_burning_not_intentionnal
Dec 22, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bchamagne
reviewed
Dec 9, 2022
tenmoves
reviewed
Dec 13, 2022
6942b01
to
829d1a8
Compare
I think you can also remove this part as it's useless now |
It's ok for me, just need to fix the error on compilation due to unused aliases, and dialyzer issue with the |
333a929
to
c952364
Compare
ff5c9b0
to
003833c
Compare
Neylix
approved these changes
Dec 22, 2022
samuelmanzanera
approved these changes
Dec 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…l (#711)
Description
Store burning fee movements only if they are intentionnals
Fixes # (issue)
Now checking if the burning node address is part of the transaction movement list's recipients, to guess if fee burning was intentionnal. If not intentionnal, remove the burning address from resolved io storage nodes
kept the test wich will add the burning address to the transaction movements if some burning movements have been recorded from point above.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
test coming soon
Checklist: