Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix request timeout #766

Merged

Conversation

Neylix
Copy link
Member

@Neylix Neylix commented Dec 12, 2022

Description

  • Fix timeout on replication so the task don't fall in timeout before the message timeout
  • Update the timeout to 4s for fetch the context during mining validation (mining timeout for getting cross validation node context is 5sec)
  • Remove the task in post_bootstrap while re syncing the network chain

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Neylix Neylix added bug Something isn't working mining Involve transaction validation and mining bootstrap replication labels Dec 12, 2022
@samuelmanzanera samuelmanzanera merged commit 67a9705 into archethic-foundation:develop Dec 12, 2022
@Neylix Neylix deleted the Fix-request-timeout branch March 6, 2023 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bootstrap bug Something isn't working mining Involve transaction validation and mining replication
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants