Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TransactionChain pagination in the explorer #773

Merged

Conversation

bchamagne
Copy link
Member

Description

A transaction chain might contain thousands of transactions. We do not want to load them all on page load.
This PR add an infinite scrolling to this page.
I removed the form option "find last" because it is now the default behaviour. There's no reason to see only a subset of a transaction chain.

Fixes #764

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Tests added to the suite
Tests on the explorer for every branch of code

Screenshot 2022-12-13 at 16-10-16 ARCHETHIC
Screenshot 2022-12-13 at 16-10-49 ARCHETHIC
Screenshot 2022-12-13 at 16-11-03 ARCHETHIC
Screenshot 2022-12-13 at 16-11-15 ARCHETHIC
Screenshot 2022-12-13 at 16-11-48 ARCHETHIC

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@apoorv-2204 apoorv-2204 self-requested a review December 14, 2022 09:12
@netboz netboz self-requested a review December 14, 2022 10:53
@samuelmanzanera samuelmanzanera added the core team Assigned to the core team label Dec 15, 2022
@Neylix
Copy link
Member

Neylix commented Dec 19, 2022

I have some error on the display, Is looks like it's displaying the last transaction but in reverse order before displaying the expected output
image

@bchamagne
Copy link
Member Author

I have some error on the display, Is looks like it's displaying the last transaction but in reverse order before displaying the expected output image

Nice catch! It happened because I did not serialize the order flag. It's fixed now

@samuelmanzanera samuelmanzanera merged commit 64a8a95 into archethic-foundation:develop Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core team Assigned to the core team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add pagination in the explorer's chain page
4 participants