Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve Message ReplicationError do not handle all error_762 #780

Conversation

apoorv-2204
Copy link
Contributor

#762

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@apoorv-2204 apoorv-2204 marked this pull request as ready for review December 15, 2022 16:05
@apoorv-2204 apoorv-2204 self-assigned this Dec 15, 2022
@apoorv-2204 apoorv-2204 added bug Something isn't working core team Assigned to the core team quality Improve code quality labels Dec 15, 2022
Copy link
Member

@samuelmanzanera samuelmanzanera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's ok for me.
There are public functions which could be private, but otherwise it looks good.

There are public functions which could be private, but otherwise it looks good.
@samuelmanzanera samuelmanzanera merged commit e55ab00 into archethic-foundation:develop Dec 16, 2022
@apoorv-2204 apoorv-2204 deleted the message_replication_error_does_not_handle_all_error_762 branch December 22, 2022 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working core team Assigned to the core team quality Improve code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants