-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fetch and assign async inputs and token details on transaction detail live #781
fetch and assign async inputs and token details on transaction detail live #781
Conversation
|> assign(:token_properties, %{}) | ||
end | ||
|
||
defp async_assign_uco_price(timestamp) do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this one is not necessary to use async here as it's a direct read of the ETS table.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok thanks, so I will keep everything inside handle_transaction function, except the 3 fields related to tokens and inputs.
do you think it's useful to first process inputs send a msg and assign and then spawn another task for tokens or it's not worth it ? (I think it's not worth it)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it might, because the token information is a "good to have" but not a "must to have", whereas the list of inputs is a hard requirement.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Thanks for the PR. Seems ok for me. |
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #774
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: