Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent HTTP/WS request when node is bootstraping #788

Merged

Conversation

bchamagne
Copy link
Member

Description

HTTP endpoints will return a 503 when node is bootstraping
WS endpoints will fail when node is bootstraping

Fixes #767

Type of change

  • Feature

How Has This Been Tested?

Added test to the suite
Manually tested on explorer for HTTP
Manually tested with a tool for WS

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@apoorv-2204 apoorv-2204 self-requested a review December 19, 2022 15:52
Copy link
Contributor

@apoorv-2204 apoorv-2204 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lib/archethic_web/controllers/up_controler.ex
nice to have this to up_controller.ex

lib/archethic_web/controllers/up_controler.ex Show resolved Hide resolved
@Neylix Neylix merged commit a2aa6ec into archethic-foundation:develop Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent HTTP requests when the node is bootstrapping
4 participants