UPNP Port Forwarding Fail On Local IP Change#698

[apoorv-2204]

Description

Attempt to resolve upnp_port_forwarding_fail_on_local_ip_change#698.

• If there is no redirection -> continue and forward port -> Archethic.Networking.IPLookup.NATDiscovery.MiniUPNP.open(port)
• If there is a redirection on the same local ip -> continue and forward port (to update time limit)
  miniupnpc duration set to 0 as for mapping for a lifetime
• If there is a redirection on a different local ip -> remove the existing redirection then continue and forward port
  Archethic.Networking.IPLookup.NATDiscovery.MiniUPNP, we expect this to fail and capture conflict mapping entry
  error .revoke that port and assigns to the node

Fixes

• Upnp port forwarding fail on local ip change #698

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

• When the port forwarding fails , we capture the error, and remove port rule , and redo the rule.
  Screenshot shows working of code, trying to imitate that condition ,we expect same when node fails to port forward.

Checklist:

• My code not follows the style guidelines of this project
• I have not performed a self-review of my own code
• I have commented my code, particularly in easy-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate 20 new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

[bchamagne]

Just read the code, I did not test it.

[apoorv-2204]

[samuelmanzanera]

Code seems ok