Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display the size when listing the files of a directory #807

Merged
merged 3 commits into from
Jan 24, 2023
Merged

Display the size when listing the files of a directory #807

merged 3 commits into from
Jan 24, 2023

Conversation

SamantaTarun
Copy link
Contributor

@SamantaTarun SamantaTarun commented Jan 5, 2023

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #800

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Manual tests
    image

with internal dir
image

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@tarunsamanta2k20
#800

@samuelmanzanera samuelmanzanera added external contribution Contribution by non core team feature New feature request web hosting issue regarding web hosting labels Jan 5, 2023
@samuelmanzanera samuelmanzanera changed the title first commit Display the size when listing the files of a directory Jan 5, 2023
@@ -116,6 +116,7 @@
<thead>
<tr>
<th>Name</th>
<th class="size">Size(Bytes)</th>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to define the css class called size.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will update that. No problem with it. Please tell me how to view the below screen in localhost.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hello, you can follow this doc #800 (comment) to view the screen

@@ -147,6 +148,7 @@
</tbody>
</table>
</td>
<td class="size"><%= file.size %></td>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same "size" css class isn't defined

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tenmoves

Yes I know, but i am asking you how to view this indexof screen in localhost.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also file.size will not work because we don't provide this field in lib/archethic_web/controllers/api/web_hosting_controller/directory_listing.ex

@bchamagne
Copy link
Member

@tarunsamanta2k20 , any update on this?

@SamantaTarun
Copy link
Contributor Author

SamantaTarun commented Jan 17, 2023

@tarunsamanta2k20 , any update on this?

@bchamagne
Will do by tomorrow

@tenmoves tenmoves added the core team Assigned to the core team label Jan 24, 2023
@Neylix Neylix merged commit 0118d6a into archethic-foundation:develop Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core team Assigned to the core team external contribution Contribution by non core team feature New feature request web hosting issue regarding web hosting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AEWeb: display the size when listing the files of a directory
5 participants