Add getGenesisAddress query to graphql

[herissondev]

Description

This Pr aims to add a getGenesisAddress query to graphql to make it easier to find the genesis address of a transaction.

Type of change

• New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Start a node, open the explorer, find a transaction and query the graphql endpoint to retrieve the genesis address.

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

[tenmoves]

Hello, ArchethicWeb should be agnostic to the underlying architecture of the archethic project ( it should only interact with the public api in the Archethic module).
I would suggest to change this call to Archethic.fetch_genesis_address_remotely

[tenmoves]

you don't need a Task here, I would call directly the function in this case.

[herissondev]

Hello, ArchethicWeb should be agnostic to the underlying architecture of the archethic project ( it should only interact with the public API in the Archethic module).

Ok thanks, I'll fix that! Could you explain to me why it should be agnostic to the underlying architecture of the archethic project, I don't really understand?

[tenmoves]

ArchethicWeb represents the frontend and Archethic represents the backend logic, in here they are in the same repository but this can change someday in the future, also we try to follow the hexagonal architecture (some call it clean architecture).

Finally if the web only depends on the public api, it means that if we refactor the whole backend tomorrow we will not need to change the web part and separate people / teams can work independently on different parts of the project.

Feel free to ping me if it isn't clear.

[herissondev]

Very clear, thanks for the explanation!

I tried using the call Archethic.fetch_genesis_address_remotely as you suggested however it seems to always return the same address as entered.

here is the code:

def get_genesis_address(address) do
    case Archethic.fetch_genesis_address_remotely(address) do
      {:ok, genesis_address} ->
        {:ok, %{genesis: genesis_address}}

      _ ->
        {:ok, %{genesis: address}}
    end
end

Correcting the code by using TransactionChain.fetch_genesis_address_remotely(address) fixes the issue.
Do you have any idea why or what I might be doing wrong?

[tenmoves]

you can look at the definition here: https://github.com/archethic-foundation/archethic-node/blob/develop/lib/archethic.ex#L246

[tenmoves]

this part need to be tested, you can have a look at test/archethic_web/graphql_schema_test.exs

[samuelmanzanera]

Also, I think you could rename it as genesisAddress , because the entire graphQL API is readonly. Hence, the get could be omitted I guess.

[herissondev]

This is a fix to Archethic.fetch_genesis_address_remotly which does not return a correct map when genesis_address is matched.

see 871f952

[samuelmanzanera]

Why create another type for the genesis address ?

[herissondev]

probably not needed indeed, will update it.

[herissondev]

Why create another type for the genesis address ?

Actually, I think it is needed. This query only returns the genesis address so I have to create a new type to only return the map genesis: address. Or am I getting this wrong ?

[herissondev]

Thanks to @Neylix I was able to understand what was meant to do. The genesisAddress type was removed.

[bchamagne]

neat!