Forwarding random port with upnpc #700

[apoorv-2204]

Description

We chose a random port , from a list of unassigned ports as per IANA.

Fixes

• Forwarding random port with upnpc #700

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Manual

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

[samuelmanzanera]

Code seems ok for me

[bchamagne]

I see some functions that use this code are completely ignoring the random port:
ex: Archethic.Networking.Scheduler.open_ports

Not an issue, I didn't notice the force = false flag.

[bchamagne]

what about HTTP(S) port, you don't want to open random port for them (ex: ArchethicWeb.Supervisor.init)

Not an issue, I didn't notice the force = false flag.

[samuelmanzanera]

@apoorv-2204 Could you check why the CI is not passing ?

[apoorv-2204]

@apoorv-2204 Could you check why the CI is not passing ?

Thanks for pointing it out

[Neylix]

On line 21 of PortForwarding module, if the function do_try_open_port return an error, the fallback is never called so the random port is never published

[apoorv-2204]

On line 21 of PortForwarding module, if the function do_try_open_port return an error, the fallback is never called so the random port is never published

{:ok, port} <- do_try_open_port(port) do
      {:ok, port}