Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix truncate on nil value #820

Merged
merged 1 commit into from
Jan 11, 2023
Merged

Conversation

Neylix
Copy link
Member

@Neylix Neylix commented Jan 10, 2023

Description

Fix a bug while aggregating a summary aggregate without availability adding time.
This bug is caused when the function BeaconChain.fetch_and_aggregate_summary do not retrieve any beacon summary, by default it create an empty summary aggregate with en empty list of availability adding time.
So when aggregating this empty summary aggregate, a nil value is passed to the trunc function which cause crashes

Fixes #787

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Neylix Neylix added bug Something isn't working beacon chain Involve BeaconChain labels Jan 10, 2023
@Neylix Neylix merged commit b698774 into archethic-foundation:develop Jan 11, 2023
@Neylix Neylix deleted the fix-trunc-nil branch January 11, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beacon chain Involve BeaconChain bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Aggregate crash due to nil
2 participants