Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix replication chain ingestion #821

Conversation

Neylix
Copy link
Member

@Neylix Neylix commented Jan 10, 2023

Description

There is some case where a node should replicate a transaction but it do not due to some latency or network issue. If there is a new transaction in this chain and the node is again storage node of this transaction, it will store the previous transaction without ingesting data as it should have been done.
This PR fix this problem by ingesting if needed the previous transaction of a chain

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Neylix Neylix added bug Something isn't working replication labels Jan 10, 2023
Refactor if statement
@samuelmanzanera samuelmanzanera merged commit eaf9ed1 into archethic-foundation:develop Jan 11, 2023
@Neylix Neylix deleted the fix-replication-chain-ingestion branch January 11, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working replication
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants