Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow 10 seconds of drift between validators #828

Merged
merged 1 commit into from
Jan 13, 2023

Conversation

samuelmanzanera
Copy link
Member

Description

In production, we have sometimes atomic commitment which is not reached because the timestamp validation is too strict.
This PR aims to increase the boundary of the validation time for 10s.
This number is significant in terms of latency and prevent too broad drift.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@samuelmanzanera samuelmanzanera added bug Something isn't working mining Involve transaction validation and mining core team Assigned to the core team labels Jan 13, 2023
@Neylix Neylix merged commit faa6162 into develop Jan 13, 2023
@Neylix Neylix deleted the increase_timestamp_boundary_validatioon branch January 13, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working core team Assigned to the core team mining Involve transaction validation and mining
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants