Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify the hash algorithm in the sc library functions #610 #834

Merged
merged 1 commit into from
Jan 24, 2023
Merged

Specify the hash algorithm in the sc library functions #610 #834

merged 1 commit into from
Jan 24, 2023

Conversation

apoorv-2204
Copy link
Contributor

@apoorv-2204 apoorv-2204 commented Jan 16, 2023

Description

  • This pr Updates the existing function in SC library hash to support multiple hash algos.
      hash("data","sha256")
      hash("data","sha512")   
      hash("data","sha3_256")
      hash("data","sha3_512")
      hash("data","blake2b")

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

  • Unit Tests

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@apoorv-2204 apoorv-2204 added the smart contracts Involve smart contracts label Jan 16, 2023
@apoorv-2204 apoorv-2204 self-assigned this Jan 16, 2023
@apoorv-2204 apoorv-2204 marked this pull request as ready for review January 17, 2023 08:32
@apoorv-2204 apoorv-2204 added the core team Assigned to the core team label Jan 17, 2023
@Neylix Neylix merged commit 806acd1 into archethic-foundation:develop Jan 24, 2023
@apoorv-2204 apoorv-2204 deleted the specify_the_hash_algorithm_in_the_SC_library_functions_#610 branch February 6, 2023 14:58
@samuelmanzanera samuelmanzanera added the feature New feature request label May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core team Assigned to the core team feature New feature request smart contracts Involve smart contracts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Specify the hash algorithm in the SC library functions
3 participants