Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix previous chain stream #837

Merged

Conversation

Neylix
Copy link
Member

@Neylix Neylix commented Jan 17, 2023

Description

For the previous chain stream during replication, we don't fetch chain if the previous address of the transaction is the genesis address of the chain.
Also we stop the stream to the specified address to not crash during self repair

Fixes #835

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Updated unit test
Run 2 nodes, wait for some summaries
start a third node, the self repair should not crash for transaction_already_exists error

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Neylix Neylix added bug Something isn't working self repair Involve SelfRepair mechanism replication labels Jan 17, 2023
@samuelmanzanera samuelmanzanera merged commit e60aa85 into archethic-foundation:develop Jan 17, 2023
@Neylix Neylix deleted the fix-previous-chain-stream branch January 17, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working replication self repair Involve SelfRepair mechanism
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stop replication at previous transaction while streaming previous chain
2 participants