Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix submit button on the settings page #840

Merged
merged 1 commit into from
Jan 18, 2023

Conversation

samuelmanzanera
Copy link
Member

Description

After the update of the Phoenix deps, a PR introduced a regression about the html button in the from of the settings page.

This PR fixes the HTML code.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Start a node
  • Go the the settings page: http://localhost:4000/settings
  • Change the reward address
  • Click on the button "Save"
  • The update should be have been taken

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@samuelmanzanera samuelmanzanera added bug Something isn't working UI Invole user interface labels Jan 18, 2023
@samuelmanzanera samuelmanzanera merged commit be48860 into develop Jan 18, 2023
@samuelmanzanera samuelmanzanera deleted the fix_settings_button_submit branch January 18, 2023 11:34
tenmoves pushed a commit to tenmoves/archethic-node that referenced this pull request Jan 18, 2023
Neylix pushed a commit that referenced this pull request Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working UI Invole user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants