Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

control number of decimals in prices returned by oracle #845

Conversation

tenmoves
Copy link
Contributor

Description

since we added multiple sources for the returned prices in the oracle, different source return different number of decimals however this number is fixed depending on the currency.

see => http://www.londonfx.co.uk/ccylist.html and iso 4217

this impacts the bridge and the wallet.

Fixes #842

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@tenmoves tenmoves added bug Something isn't working oracle chain Involve OracleChain core team Assigned to the core team labels Jan 18, 2023
@tenmoves tenmoves self-assigned this Jan 18, 2023
@Neylix Neylix changed the base branch from develop to 1.0.7 January 18, 2023 17:30
@Neylix Neylix force-pushed the control_number_of_decimals_in_prices_returned_by_oracle branch from 27eb2c9 to b94d254 Compare January 18, 2023 18:06
@Neylix Neylix merged commit 2f66836 into archethic-foundation:1.0.7 Jan 18, 2023
samuelmanzanera pushed a commit that referenced this pull request Jan 19, 2023
* control number of decimals in prices returned by oracle

* added more tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working core team Assigned to the core team oracle chain Involve OracleChain
Projects
None yet
Development

Successfully merging this pull request may close these issues.

control number of decimals in prices returned by oracle
2 participants