Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SC: change default contract type #846

Merged

Conversation

bchamagne
Copy link
Member

Description

Change default contract type from transfer to contract. We can now have contracts that don't necessarily have transfers. Plus added data & contract types as valid argument to the set_type action.

Fixes #844

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Tested this scenario via the transaction builder:

condition inherit: [
	content: true
]

condition transaction: [
	uco_transfers: size() > 0
]

actions triggered_by: transaction do
	set_content "hello"
end

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@bchamagne bchamagne added bug Something isn't working smart contracts Involve smart contracts labels Jan 18, 2023
@Neylix Neylix merged commit b5bc658 into archethic-foundation:develop Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working smart contracts Involve smart contracts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SC: if there is no uco_transfer, the contract cannot create a new tx
3 participants