Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SC: Add TransactionStatements functions to work with lists #849

Merged
merged 5 commits into from
Feb 1, 2023

Conversation

bchamagne
Copy link
Member

@bchamagne bchamagne commented Jan 19, 2023

Description

Add TransactionStatements functions to work with lists.
Authorize Keyword lists in actions. I transformed the whitelist into a blacklist (whitelisting all keyword and blacklisted some keywords from some functions)

Part of #826

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Tests added and tested with the explorer

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@bchamagne bchamagne added feature New feature request smart contracts Involve smart contracts labels Jan 19, 2023
@bchamagne
Copy link
Member Author

Latest commit added plenty of unit tests related to another branch (the one with the reduce fn). I suggest not to read the tests in describe "reduce/3" do

Copy link
Member

@samuelmanzanera samuelmanzanera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I think the PR does the work.
I'm not really fan of the blacklisting, but ok for now.
We should later provide a better way with whitelisting a term and blacklisting the remaining, maybe using a dedicated parser for each function.

@Neylix Neylix merged commit 7ea16d9 into archethic-foundation:develop Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature request smart contracts Involve smart contracts
Projects
Status: Done 🍻
Development

Successfully merging this pull request may close these issues.

None yet

3 participants