Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix previous on first page and next on last page of pagination component #851

Merged

Conversation

tenmoves
Copy link
Contributor

Description

previous and next button breaks the liveview component in the pagination because the returned div didn't have any liveview action attached to it.

Fixes #818

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Tested manually

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@tenmoves tenmoves added bug Something isn't working good first issue Good for newcomers UI Invole user interface core team Assigned to the core team labels Jan 19, 2023
@tenmoves tenmoves self-assigned this Jan 19, 2023
@tenmoves tenmoves force-pushed the fix_previous_and_next_pagination branch from 72c4fa7 to 51e0efc Compare January 24, 2023 16:48
@Neylix Neylix merged commit c829491 into archethic-foundation:develop Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working core team Assigned to the core team good first issue Good for newcomers UI Invole user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

previous don't work on last page
2 participants