Pr 824 integrate hydrating cache oracle chain

[netboz]

Description

This will address ticket #824 and
Fixes #824
Fixes #836

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• This change requires a documentation update

There is still some refinement needed.

How Has This Been Tested?

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

[netboz]

I need to do a final refinement, like to remove unused mocks and I would like to add metrics also, if possible.

[bchamagne]

2 suggestions for me:

folder

there is an "archethic_cache" folder at root, I would move the HydratingCache in here.

config

I think there are 2 configurations mixed in 1.
Here you have a UCOPrice config that contains both providers & cache configuration (refreshrate/ttl).
Then in the Supervisor, you transform this into {MFA}.
I suggest to have the {MFA} directly in a HydratingCache config (adding services should not require code changes in the cache).

uco_providers =  [
  Archethic.OracleChain.Services.UCOPrice.Providers.CoinX,
  Archethic.OracleChain.Services.UCOPrice.Providers.CoinY,
  Archethic.OracleChain.Services.UCOPrice.Providers.CoinZ
  ]

config :archethic, Archethic.OracleChain.Services.UCOPrice,
  providers: uco_providers
  
config :archethic, Archethic.Utils.HydratingCache,
   [<some_other_cache>] ++ 
    Enum.map(uco_providers,&({&1, {&1, :fetch, [["eur", "usd"]]}, 60_000, :infinity}))

[apoorv-2204]

2 suggestions for me:

folder

there is an "archethic_cache" folder at root, I would move the HydratingCache in here.

config

I think there are 2 configurations mixed in 1. Here you have a UCOPrice config that contains both providers & cache configuration (refreshrate/ttl). Then in the Supervisor, you transform this into {MFA}. I suggest to have the {MFA} directly in a HydratingCache config (adding services should not require code changes).

uco_providers =  [
  Archethic.OracleChain.Services.UCOPrice.Providers.CoinX,
  Archethic.OracleChain.Services.UCOPrice.Providers.CoinY,
  Archethic.OracleChain.Services.UCOPrice.Providers.CoinZ
  ]

config :archethic, Archethic.OracleChain.Services.UCOPrice,
  providers: uco_providers
  
config :archethic, Archethic.Utils.HydratingCache,
   [<some_other_cache>] ++ 
    Enum.map(uco_providers,&({&1, {&1, :fetch, [["eur", "usd"]]}, 60_000, :infinity}))

maybe we can create a behavior for cache. like @samuelmanzanera has done in Node KeyStore, shared secrets keystore for the
use of ets tables.

[bchamagne]

I updated a few things as we discussed, I suggest to read commit by commit.

[bchamagne]

Looks good to me, just a slight comment about Archethic.OracleChain.ServiceCacheSupervisor which I believe is not helpful, but no harm here.

[samuelmanzanera]

Looks good to me, just a slight comment about Archethic.OracleChain.ServiceCacheSupervisor which I believe is not helpful, but no harm here.

Yes, the point is to enforce implementation to leverage hydrating cache for the fetching.