added get_token_id function in smart contract library #858
+190
−73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tenmoves
added
feature
tenmoves
force-pushed
the
add_token_id_func_in_sc
branch
from
a20029e
to
3836a48
Compare
|
fot the test I created a token, then a smart contract where we used the token id in the content, after transfer we can see that the content was updated with the token_id |
Neylix
requested changes
Jan 30, 2023
tenmoves
force-pushed
the
add_token_id_func_in_sc
branch
from
3836a48
to
67d802f
Compare
Neylix
requested changes
Jan 31, 2023
lib/archethic/utils.ex
Outdated
| @doc """ | ||
| get token properties based on the genesis address and the transaction | ||
| """ | ||
| @spec get_token_properties(binary(), Transaction.t()) :: {:ok, map()} | {:error, atom()} |
There was a problem hiding this comment.
You may specify the possible atom return when an error occur, it will be easier to understand the possible result
lib/archethic/utils.ex
Outdated
| name: Map.get(map, "name", ""), | ||
| supply: Map.get(map, "supply"), | ||
| symbol: Map.get(map, "symbol", ""), | ||
| type: type, |
There was a problem hiding this comment.
The type should be retrieve from the map, the expected type are fungible or non-fungible and not the transaction type
Neylix
approved these changes
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #640
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: