Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SC: ActionInterpreter.execute might return nil to not create a next tx #863

Merged
merged 3 commits into from
Feb 1, 2023

Conversation

bchamagne
Copy link
Member

@bchamagne bchamagne commented Jan 25, 2023

Description

This PRs allows smart contracts to end without a "next_transaction".
I know @Neylix wants to go one step further (allow contract to have a next transaction even when it ends on a non-transaction-statements) but I believe it should be done in a new issue. (CREATED: #870)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Tested with a smart contract that use this code:

actions triggered_by: interval, at: "0 * * * *" do	
	calls = get_calls() 
	if calls != [] do 
		[...]
		add_uco_transfers(transfers)
	end
end

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Neylix Neylix merged commit 4cc5bae into archethic-foundation:develop Feb 1, 2023
@samuelmanzanera samuelmanzanera added the feature New feature request label May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants