Add algorithm to compute the network coordinates #878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tenmoves
reviewed
Jan 31, 2023
|
rebase? |
bchamagne
reviewed
Feb 23, 2023
tenmoves
reviewed
Feb 23, 2023
tenmoves
reviewed
Feb 23, 2023
cluster
reviewed
Feb 23, 2023
tenmoves
reviewed
Feb 23, 2023
tenmoves
reviewed
Feb 23, 2023
Comment on lines
73
to
83
| b = | ||
| 1..(matrix_size - 1) | ||
| |> Enum.map(fn i -> | ||
| excluded_first_row_tensor | ||
| |> Nx.slice([i - 1, 0], [1, i]) | ||
| |> Nx.power(2) | ||
| |> Nx.sum() | ||
| end) | ||
| |> Nx.stack() | ||
| |> Nx.sum() | ||
| |> Nx.to_number() |
There was a problem hiding this comment.
it may be worth it to precise that that the indexes start at 0 vs 1 in the formula
There was a problem hiding this comment.
Usually, algorithm start indexes a 1, while programming language start indexes at 0. I guess this is a standard way of thinking.
tenmoves
approved these changes
Feb 23, 2023
samuelmanzanera
force-pushed
the
network_patch
branch
from
dee78dc
to
d0af8e9
Compare
tenmoves
added a commit
to tenmoves/archethic-node
that referenced
this pull request
Mar 10, 2023
…oundation#878)" This reverts commit f17a993.
tenmoves
added a commit
to tenmoves/archethic-node
that referenced
this pull request
Mar 17, 2023
…oundation#878)" This reverts commit f17a993.
tenmoves
added a commit
to tenmoves/archethic-node
that referenced
this pull request
Mar 21, 2023
…oundation#878)" This reverts commit f17a993.
tenmoves
added a commit
to tenmoves/archethic-node
that referenced
this pull request
Mar 28, 2023
…hethic-foundation#878)"" This reverts commit 839f793.
tenmoves
added a commit
to tenmoves/archethic-node
that referenced
this pull request
Mar 28, 2023
…oundation#878)" This reverts commit f17a993.
tenmoves
added a commit
to tenmoves/archethic-node
that referenced
this pull request
Mar 28, 2023
…hethic-foundation#878)"" This reverts commit 839f793.
samuelmanzanera
added
API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #159
Type of change
How Has This Been Tested?
TODO: need to provide more way to tests (Awaiting response from @internet-zero)
Checklist: